Skip to content

Conversation

@jld01
Copy link
Contributor

@jld01 jld01 commented Sep 7, 2025

No description provided.

@jld01 jld01 requested a review from jonahgraham September 7, 2025 15:17
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

Test Results

   636 files     636 suites   37m 11s ⏱️
11 440 tests 11 295 ✅ 144 💤 1 ❌
11 462 runs  11 317 ✅ 144 💤 1 ❌

For more details on these failures, see this check.

Results for commit 98e6e4b.

♻️ This comment has been updated with latest results.

@jld01 jld01 force-pushed the repo-prep-12.3.0 branch 2 times, most recently from d49d250 to 9b9514a Compare September 7, 2025 16:48
@jld01 jld01 marked this pull request as ready for review September 7, 2025 19:28
@jld01
Copy link
Contributor Author

jld01 commented Sep 8, 2025

Test failure is unrelated and a known issue #1290.

Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - with the caveat of the open conversation items + adding N&N right away, which you recommended in https://github.com/eclipse-cdt/cdt/pull/1190/files#r2237471173

@jonahgraham jonahgraham added this to the 12.3.0 milestone Sep 9, 2025
@jonahgraham jonahgraham added the releng Release engineering and project management label Sep 9, 2025
@jonahgraham
Copy link
Member

I added releng label + 12.3.0 milestone to this PR.

@jld01 jld01 force-pushed the repo-prep-12.3.0 branch 2 times, most recently from 9cc4853 to 4163aba Compare September 10, 2025 07:53
@jld01 jld01 merged commit cb25891 into eclipse-cdt:main Sep 10, 2025
4 of 5 checks passed
@jonahgraham
Copy link
Member

Thanks @jld01 - we can discuss how it went at the CDT call today #1298 if desired.

@jonahgraham
Copy link
Member

I haven't looked yet as to why - but this failed once merged:

image

@jld01 jld01 deleted the repo-prep-12.3.0 branch November 7, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releng Release engineering and project management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants